Support Horizontal Scaling#1048
Merged
Merged
Conversation
github-actions
Bot
added
documentation
bjee19
reviewed
Sep 8, 2023
sjberman
reviewed
Sep 11, 2023
pleshakov
reviewed
Sep 12, 2023
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
more comments:
(1) Would it make sense to add something about leader election to the architecture doc?
(2) What removes the leader election lock resource? Do we need to update our deinstallation instructions (helm and manifests) if it is not removed automatically?
Contributor
Author
(1) Sure, I can add something to the architecture doc. |
sjberman
reviewed
Sep 14, 2023
sjberman
approved these changes
Sep 14, 2023
pleshakov
reviewed
Sep 15, 2023
pleshakov
reviewed
Sep 15, 2023
kate-osborn
force-pushed
the
feat/horizontal-scaling
branch
from
50e907a to
d4b4423
Compare
sjberman
reviewed
Sep 18, 2023
bjee19
reviewed
Sep 18, 2023
bjee19
reviewed
Sep 18, 2023
bjee19
reviewed
Sep 18, 2023
Contributor
|
There is a line here that is: "Once we add leader election, the control plane will be able to scale.", would we like to change that now? |
Contributor
Author
No, that's in an old design document. We don't need to keep those up-to-date. |
kate-osborn
force-pushed
the
feat/horizontal-scaling
branch
from
f0f0ed8 to
ed875d2
Compare
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
kate-osborn
force-pushed
the
feat/horizontal-scaling
branch
from
ed875d2 to
28cd3b1
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: NKG cannot be scaled horizontally because all replicas will write statuses to the Gateway API resources. Solution: Add leader election to the status updater so that only one replica of NKG will write statuses to the Gateway API resources. Leader election is enabled by default but can be disabled via a cli arg --leader-election-disable. The lock name used for leader election can be configured via the cli arg --leader-election-lock-name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NKG cannot be scaled horizontally because all replicas will write statuses to the Gateway API resources.
Solution: Add leader election to the status updater so that only one replica of NKG will write statuses to the Gateway API resources. Leader election is enabled by default but can be disabled via a cli arg
--leader-election-disable. The lock name used for leader election can be configured via the cli arg--leader-election-lock-name.Testing: Verified leader election works with multiple replicas.
Closes #637
Checklist
Before creating a PR, run through this checklist and mark each as complete.